I suggest you ...

Refactor IRedisSubscription interface to be more intuitive

https://github.com/ServiceStack/ServiceStack.Redis/wiki/RedisPubSub gives a good example of how to use pub sub pattern. However, from the documentation that is provided with the API, I don't think there's a way to infer that in the property Action<string, string> OnMessage { get; set; } the first param is the channel,
and the second one is the msg. Other functions are pretty self explanatory, but for this one, I don't feel like I should have to thumb through a bunch of examples to have to figure out how to use it.
A more self explanatory pattern would be to have an actual event OnMessage and then have the args contain the channel and msg data.

3 votes
Vote
Sign in
Check!
(thinking…)
Reset
or sign in with
  • facebook
  • google
    Password icon
    Signed in as (Sign out)
    You have left! (?) (thinking…)
    Anonymous shared this idea  ·   ·  Flag idea as inappropriate…  ·  Admin →
    declined  ·  AdminDemis J Bellot (Developer, ServiceStack) responded  · 

    The OnMessage is documented on both the wiki and the home page:
    https://github.com/ServiceStack/ServiceStack.Redis#usage

    If the API isn’t self-explanatory checkout the docs to see if there’s an example, otherwise feel free to ask a question on our Forums or StackOverflow.

    I’ve added API docs in this commit https://github.com/ServiceStack/ServiceStack.Redis/commit/cc5f4ba416d5c904a9b483adf92a504c2e9e9dd9

    But we wont be making any breaking changes to existing APIs.

    1 comment

    Sign in
    Check!
    (thinking…)
    Reset
    or sign in with
    • facebook
    • google
      Password icon
      Signed in as (Sign out)
      Submitting...
      • Anonymous commented  ·   ·  Flag as inappropriate

        Fair enough. Thanks for adding in that explicit documentation. That really speeds up dev time :)

      Feedback and Knowledge Base